[chore] log process manager shutdown with more details (#49437)

Signed-off-by: Andy Xie <andy.xning@gmail.com>
This commit is contained in:
Ning Xie
2026-07-31 11:55:09 -07:00
committed by GitHub
parent 726ef437a1
commit 9a7ae4b808
+17 -6
View File
@@ -600,14 +600,18 @@ def shutdown(procs: list[BaseProcess], timeout: float | None = None) -> None:
timeout = 5.0
logger.debug(
"[shutdown] Process manager: start process_count=%d timeout=%ss",
"[shutdown] Process manager: start process_count=%d timeout=%ss names=%s",
len(procs),
timeout,
(",").join([proc.name for proc in procs]),
)
# Shutdown the process.
for proc in procs:
if proc.is_alive():
logger.info(
"[shutdown] Process manager: send sigterm to process %s", proc.name
)
proc.terminate()
# Allow time for remaining procs to terminate.
@@ -619,15 +623,22 @@ def shutdown(procs: list[BaseProcess], timeout: float | None = None) -> None:
if proc.is_alive():
proc.join(remaining)
remaining_pids = [
proc.pid for proc in procs if proc.is_alive() and proc.pid is not None
remaining_procs = [
(proc.pid, proc.name)
for proc in procs
if proc.is_alive() and proc.pid is not None
]
if remaining_pids:
if remaining_procs:
logger.warning(
"[shutdown] Process manager: force killing remaining processes count=%d",
len(remaining_pids),
len(remaining_procs),
)
for pid, proc_name in remaining_procs:
logger.warning(
"[shutdown] Process manager: force killing remaining process %s pid %d",
proc_name,
pid,
)
for pid in remaining_pids:
kill_process_tree(pid)
logger.debug_once("[shutdown] Process manager: complete")