[Bugfix] Fix parallel_tool_calls=null crash in Responses API from_request() (#48098)
Signed-off-by: mahadrehmann <mahadrehman04@gmail.com> Signed-off-by: Mahad Rehman <114791389+mahadrehmann@users.noreply.github.com> Co-authored-by: muhammadfawaz1 <135441198+professorsab@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Chauncey <chaunceyjiang@gmail.com>
This commit is contained in:
co-authored by
muhammadfawaz1
Copilot Autofix powered by AI
Chauncey
parent
313fae3e89
commit
c0302d9497
@@ -4,7 +4,10 @@
|
||||
import pytest
|
||||
from pydantic import ValidationError
|
||||
|
||||
from vllm.entrypoints.openai.responses.protocol import ResponsesRequest
|
||||
from vllm.entrypoints.openai.responses.protocol import (
|
||||
ResponsesRequest,
|
||||
ResponsesResponse,
|
||||
)
|
||||
|
||||
SAMPLE_TOOL = {
|
||||
"type": "function",
|
||||
@@ -182,3 +185,42 @@ def test_responses_request_empty_tools_named_tool_choice():
|
||||
"tool_choice": NAMED_TOOL_CHOICE,
|
||||
}
|
||||
)
|
||||
|
||||
|
||||
# Regression tests for parallel_tool_calls=null crash in Responses API
|
||||
# (from_request() passed None to ResponsesResponse.parallel_tool_calls,
|
||||
# a non-optional bool field, causing a Pydantic ValidationError during
|
||||
# response construction)
|
||||
@pytest.mark.parametrize(
|
||||
"value,expected",
|
||||
[
|
||||
(True, True),
|
||||
(False, False),
|
||||
(None, True), # null must resolve to the documented default (true)
|
||||
],
|
||||
)
|
||||
def test_responses_response_parallel_tool_calls_null_resolves_to_default(
|
||||
value, expected
|
||||
):
|
||||
request = ResponsesRequest.model_validate(
|
||||
{"input": "Hello", "model": "test-model", "parallel_tool_calls": value}
|
||||
)
|
||||
sampling_params = request.to_sampling_params(default_max_tokens=16)
|
||||
r = ResponsesResponse.from_request(
|
||||
request=request,
|
||||
sampling_params=sampling_params,
|
||||
model_name="test-model",
|
||||
created_time=0,
|
||||
output=[],
|
||||
status="completed",
|
||||
usage=None,
|
||||
)
|
||||
assert r.parallel_tool_calls == expected
|
||||
|
||||
|
||||
def test_responses_request_parallel_tool_calls_null_accepted():
|
||||
"""Client sending null must be accepted at request validation time."""
|
||||
req = ResponsesRequest.model_validate(
|
||||
{"input": "Hello", "model": "test-model", "parallel_tool_calls": None}
|
||||
)
|
||||
assert req.parallel_tool_calls is None
|
||||
|
||||
@@ -749,7 +749,9 @@ class ResponsesResponse(OpenAIBaseModel):
|
||||
output=output,
|
||||
input_messages=input_messages,
|
||||
output_messages=output_messages,
|
||||
parallel_tool_calls=request.parallel_tool_calls,
|
||||
parallel_tool_calls=request.parallel_tool_calls
|
||||
if request.parallel_tool_calls is not None
|
||||
else ResponsesRequest.model_fields["parallel_tool_calls"].default,
|
||||
temperature=sampling_params.temperature,
|
||||
tool_choice=request.tool_choice,
|
||||
tools=request.tools,
|
||||
|
||||
Reference in New Issue
Block a user