[Bugfix] fix crash in postprocess for null tool args (#43862)

Signed-off-by: William-Rom <william.rom@intility.no>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
William Rom
2026-06-02 22:17:26 -07:00
committed by GitHub
co-authored by mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
parent 597bc15936
commit f0204358d9
2 changed files with 30 additions and 1 deletions
+28
View File
@@ -13,6 +13,8 @@ from vllm.assets.image import ImageAsset
from vllm.assets.video import VideoAsset
from vllm.config import ModelConfig
from vllm.entrypoints.chat_utils import (
ConversationMessage,
_postprocess_messages,
parse_chat_messages,
parse_chat_messages_async,
)
@@ -2714,3 +2716,29 @@ async def test_parse_chat_messages_video_vision_chunk_with_uuid_async(
assert conversation == expected_conversation
_assert_mm_data_is_vision_chunk_input(mm_data, 1)
_assert_mm_uuids(mm_uuids, 1, expected_uuids=[video_uuid], modality="vision_chunk")
def test_postprocess_messages_null_arguments_string():
"""arguments="null" must not reach the chat template as Python None.
json.loads("null") returns None, which causes Jinja2 templates that call
tc.arguments.items() to raise 'None' has no attribute 'items'.
The function should coerce it to {} instead.
"""
messages: list[ConversationMessage] = [
{
"role": "assistant",
"content": None,
"tool_calls": [
{
"id": "call_1",
"type": "function",
"function": {"name": "get_current_time", "arguments": "null"},
}
],
}
]
_postprocess_messages(messages)
tool_calls = messages[0]["tool_calls"]
assert tool_calls is not None
assert tool_calls[0]["function"]["arguments"] == {}
+2 -1
View File
@@ -1854,7 +1854,8 @@ def _postprocess_messages(messages: list[ConversationMessage]) -> None:
# if arguments is None or empty string, set to {}
if content := function.get("arguments"):
if not isinstance(content, (dict, list)):
function["arguments"] = json.loads(content)
parsed = json.loads(content)
function["arguments"] = parsed if parsed is not None else {}
else:
function["arguments"] = {}