[Bug][Quantization] Fix humming is_layer_skipped for compressed-tensors "re:" ignore entries (#48507)

Signed-off-by: Zhongdongming Dai <zhongdongmin@nvidia.com>
This commit is contained in:
Zhongdongming Dai
2026-07-16 07:47:42 -07:00
committed by GitHub
parent d08eebad16
commit 75bdad40b5
2 changed files with 67 additions and 2 deletions
+56
View File
@@ -0,0 +1,56 @@
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
"""Tests for humming's is_layer_skipped handling of compressed-tensors
regex ("re:") ignore entries.
Regression test: compressed-tensors checkpoints (e.g. Kimi-K2.6) list ignored
layers as regex patterns prefixed with "re:" (e.g. "re:vision_tower.*").
humming previously substring-matched these literals, so ignored layers were
never skipped and got (incorrectly) quantized -- which then diverged between
the real weight-load path (falls back to unquantized) and the dummy-load path
(stays quantized), breaking any consumer that byte-compares the two.
"""
import pytest
from vllm.model_executor.layers.quantization.humming import HummingConfig
# The real ignore list from Kimi-K2.6's compressed-tensors quantization_config.
K26_IGNORE = [
"re:.*self_attn.*",
"re:.*shared_experts.*",
r"re:.*mlp\.(gate|up|gate_up|down)_proj.*",
"re:.*lm_head.*",
"re:vision_tower.*",
"re:mm_projector.*",
]
@pytest.mark.parametrize(
"prefix,expected",
[
# ignored layers (must be skipped -> stay unquantized)
("vision_tower.encoder.blocks.0.mlp.fc0", True),
("vision_tower.encoder.blocks.16.wo", True),
("mm_projector.linear_1", True),
("language_model.model.layers.0.self_attn.o_proj", True),
("language_model.model.layers.0.mlp.gate_up_proj", True),
("language_model.model.layers.0.mlp.down_proj", True),
("language_model.model.layers.3.mlp.shared_experts.gate_proj", True),
("model.lm_head", True),
# routed experts are NOT ignored -> must be quantized
("language_model.model.layers.3.mlp.experts.383.up_proj", False),
("language_model.model.layers.3.mlp.experts.0.down_proj", False),
],
)
def test_is_layer_skipped_regex_ignore(prefix, expected):
cfg = HummingConfig(full_config={"ignore": K26_IGNORE})
assert cfg.is_layer_skipped({"ignore": K26_IGNORE}, prefix) is expected
def test_plain_substring_entries_still_work():
# bitsandbytes-style modules_to_not_convert use plain substrings.
cfg = HummingConfig()
cfg_dict = {"modules_to_not_convert": ["lm_head", "vision"]}
assert cfg.is_layer_skipped(cfg_dict, "model.vision.encoder.fc") is True
assert cfg.is_layer_skipped(cfg_dict, "model.layers.0.mlp.up_proj") is False
@@ -217,8 +217,17 @@ class HummingConfig(QuantizationConfig):
if hasattr(self, "hf_to_vllm_mapper"):
ignored_layers = self.hf_to_vllm_mapper.apply_list(ignored_layers)
if any(module_name in prefix for module_name in ignored_layers):
return True
for module_name in ignored_layers:
# compressed-tensors style entries may be regex patterns prefixed
# with "re:" (e.g. "re:vision_tower.*"). These must be regex-matched;
# plain substring matching never matches the literal "re:..." string,
# so ignored layers get silently quantized. Non-"re:" entries keep the
# existing substring behavior (e.g. bitsandbytes modules_to_not_convert).
if module_name.startswith("re:"):
if re.match(module_name[3:], prefix):
return True
elif module_name in prefix:
return True
if "lm_head" in prefix:
return True